Repository navigation
plugins: Box layout container for components panels (catalog 4) - #37420
Merged
Merged
Conversation
- Box (ui.catalog 4, since 1.4.248): direction, gap/padding/paddingX/ paddingY/margin on the gap scale, align, justify, wrap, grow, shrink, width/height/min/max (px up to 4096 or whole percents), columns, scroll, border (true or a tone), radius, background (theme surfaces or tone tints). Strict props: hex colours, CSS lengths and unknown props are dropped with a warning like other components. - Renderer maps props to theme tokens through data attributes; sizes reach inline style only as validated px or percents. - Typings, docs, skill references, gallery Layout tab; orca/testing finds Boxes and summarizes danger or warning Boxes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Plugin panels built from Orca's components can now use
Box, a general container for layout. Authors get rows, columns, grids, spacing, sizes, borders and theme backgrounds without raw HTML or CSS, so the panel still looks like Orca in light and dark.What Changed
Boxcomponent in the components catalog.ui.cataloggoes from 3 to 4, and Box is available from Orca 1.4.248.direction,columns,align,justify,wrap,grow,shrink,scroll.gap,padding,paddingX,paddingY,margin, all on the existing gap scale.width,height,min*,max*, in pixels (0–4096) or whole percents.border(trueor a tone),radius,background(muted,card, or a tone's tint).'50px','120%',styleorclassNameis dropped with a warning. Typings reject these too.orca/testing:find/findAllread Box as agroup, andsummary()adds a line for a Box tinted or bordered in danger or warning.plugin-declarative-ui.md, the skill references and the bundled guides. The components gallery gets a Layout tab and now requires Orca 1.4.248.Why
Authors needed a layout that
Stack/Row/Grid/Cardcan't express, such as a fixed-width side box or a tinted, scrolling region. Until now their only option was to leave components panels. A token-only container keeps plugins themable. We considered allowing arbitrarystyleand rejected it because it breaks theming.Linked Issue
N/A (maintainer)
Visual Proof
Taken with
orca plugin shotfrom a background dev build, using a demo panel built from Box only.Light:
Dark:
Testing
plugin shotlight and dark,plugin checkon the gallery, and atscrun of a demo plugin against the generated typings, which rejectsbackground="#fff")Also ran
pnpm lint, the changed-code quality gate, ast-grep, the anti-slop lint, the localization check, and the freshness tests for the runtime, typings and skill references.Risk
The change only adds to the catalog. Older Orca versions draw an unknown
Boxas a placeholder. The gallery example's engine floor goes up to 1.4.248. A plain revert undoes everything.Level: Low
AI Disclosure
Review
Agent skill upstream boundary
Notes
Renderer-only and the same on all platforms. SSH is not affected, because panels render on the client.
Checklist
pnpm lintand the targeted tests pass (CI covers the rest)